fix(pci): capabilities are always little-endian #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-1240004 "This virtio structure capability uses little-endian format" Signed-off-by: Jens Reidel <[email protected]>
phip1611
requested changes
Aug 26, 2025
| @@ -136,6 +136,8 @@ impl Cap { | |||
| unsafe { access.read(addr.address, addr.offset + 12) }, | |||
| ]; | |||
|
|
|||
| let data: [u32; 4] = data.map(u32::from_le); | |||
|
|
|||
| let this = unsafe { mem::transmute::<[u32; 4], Self>(data) }; | |||
There was a problem hiding this comment.
Suggested change
| let this = unsafe { mem::transmute::<[u32; 4], Self>(data) }; |
There was a problem hiding this comment.
How would you remove this? This is also not touched by the PR. 🤔
There was a problem hiding this comment.
That line is necessary to convert the raw data read to the capabilities structure, it cannot simply be dropped
There was a problem hiding this comment.
Ahhh, sorry! I accidentally read it as let this = unsafe { mem::transmute::<[u32; 4], _>(data) }; and thought it is a no-op. 🫠 Time for Feierabend :D
phip1611
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.oasis-open.org/virtio/virtio/v1.2/cs01/virtio-v1.2-cs01.html#x1-1240004
"This virtio structure capability uses little-endian format"