Skip to content

fix(pci): actually convert MMIO access to little endian #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

fix(pci): actually convert MMIO access to little endian #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/pci.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use volatile_macro::VolatileFieldAccess;

pub use crate::driver_notifications::NotificationData;
use crate::volatile::WideVolatilePtr;
use crate::{le16, le32, le64, DeviceConfigSpace, DeviceStatus, Le};
use crate::{le16, le32, le64, DeviceConfigSpace, DeviceStatus};

/// PCI Capability
///
Expand Down Expand Up @@ -234,11 +234,11 @@ impl CapData {
}

let offset_hi = unsafe { access.read(addr.address, addr.offset + 16) };
let offset_hi = Le(offset_hi);
let offset_hi = le32::from_ne(offset_hi);
let offset = le64::from([cap.offset, offset_hi]);

let length_hi = unsafe { access.read(addr.address, addr.offset + 20) };
let length_hi = Le(length_hi);
let length_hi = le32::from_ne(length_hi);
let length = le64::from([cap.length, length_hi]);

(offset, length)
Expand All @@ -253,7 +253,7 @@ impl CapData {
}

let notify_off_multiplier = unsafe { access.read(addr.address, addr.offset + 16) };
let notify_off_multiplier = Le(notify_off_multiplier);
let notify_off_multiplier = le32::from_ne(notify_off_multiplier);

Some(notify_off_multiplier)
}
Expand Down