Open
Conversation
Contributor
|
@phil-opp this looks reasonable to me. If you rebase, I can review. |
phil-opp
force-pushed
the
map-function
branch
from
ac4d400 to
9c7ff09
Compare
Member
Author
|
Rebased |
Member
|
@josephlr (friendly ping :D) do you have any comments? |
Contributor
Member
Author
|
@josephlr Thanks a lot! The past weeks have been busy for me, so I haven't had time to review these PRs yet. Feel free to ping me if you need any input from me. |
Member
Author
|
@josephlr Do you have time for a quick review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of requiring the caller to specify the target frame, this method uses a frame allocated from the frame allocator. This makes the common use case of mapping a page to an unused physical frame more convenient.
Builds upon #135, so there are some additional commits in this PR. I will rebase it as soon as #135 is merged.