Skip to content

Conversation

@newpavlov
Copy link
Member

No description provided.

@newpavlov newpavlov requested a review from dhardy January 26, 2026 14:05
runner = 'node'

[resolver]
incompatible-rust-versions = "allow"
Copy link
Member Author

@newpavlov newpavlov Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasip3 v0.4 requires Rust 1.87. Technically, we should bump rust-version for getrandom as well, but I guess it's fine to skip it in this case.

Unfortunately, this setting may complicate MSRV testing since we could pull dependencies into Cargo.lock which require a higher Rust version. I think the right way to handle this would be to execute cargo update in each MSRV job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not sufficient to use cargo update --ignore-rust-version only in the relevant tests?

Copy link
Member Author

@newpavlov newpavlov Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it could work as well. But I think we should commit latest dependency versions into Cargo.lock and test with them by default, not MSRV-compatible ones. Plus, we have more non-MSRV jobs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

- name: Generate MSRV-compatible Cargo.lock
env:
CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: "fallback"
run: cargo update

@newpavlov newpavlov merged commit 698db3b into master Jan 26, 2026
101 of 107 checks passed
@newpavlov newpavlov deleted the wasip3_v0.4 branch January 26, 2026 18:10
takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants