-
Notifications
You must be signed in to change notification settings - Fork 246
Bump wasip3 to v0.4
#790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump wasip3 to v0.4
#790
Conversation
| runner = 'node' | ||
|
|
||
| [resolver] | ||
| incompatible-rust-versions = "allow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasip3 v0.4 requires Rust 1.87. Technically, we should bump rust-version for getrandom as well, but I guess it's fine to skip it in this case.
Unfortunately, this setting may complicate MSRV testing since we could pull dependencies into Cargo.lock which require a higher Rust version. I think the right way to handle this would be to execute cargo update in each MSRV job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not sufficient to use cargo update --ignore-rust-version only in the relevant tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it could work as well. But I think we should commit latest dependency versions into Cargo.lock and test with them by default, not MSRV-compatible ones. Plus, we have more non-MSRV jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
getrandom/.github/workflows/tests.yml
Lines 373 to 376 in b229df2
| - name: Generate MSRV-compatible Cargo.lock | |
| env: | |
| CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: "fallback" | |
| run: cargo update |
No description provided.