Re-org with distr::slice, distr::weighted modules#1548
Merged
dhardy merged 17 commits intorust-random:masterfrom Jan 14, 2025
Merged
Re-org with distr::slice, distr::weighted modules#1548dhardy merged 17 commits intorust-random:masterfrom
dhardy merged 17 commits intorust-random:masterfrom
Conversation
This remains available as rand::seq::WeightError.
This isn't clear enough on GitHub Actions pages
benjamin-lieser
approved these changes
Jan 13, 2025
Member
benjamin-lieser
left a comment
There was a problem hiding this comment.
It looks fine to me (minus the two comments on the CI) and I think it makes sense to organize it in this way.
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
- Move `Slice` -> `slice::Choose`, `EmptySlice` -> `slice::Empty`
- Rename trait `DistString` -> `SampleString`
- Rename `DistIter` -> `Iter`, `DistMap` -> `Map`
- Move `{Weight, WeightError, WeightedIndex}` -> `weighted::{Weight,
Error, WeightedIndex}`
- Move `weighted_alias::{AliasableWeight, WeightedAliasIndex}` ->
`weighted::{..}`
- Move `weighted_tree::WeightedTreeIndex` ->
`weighted::WeightedTreeIndex`
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
- Move `Slice` -> `slice::Choose`, `EmptySlice` -> `slice::Empty`
- Rename trait `DistString` -> `SampleString`
- Rename `DistIter` -> `Iter`, `DistMap` -> `Map`
- Move `{Weight, WeightError, WeightedIndex}` -> `weighted::{Weight,
Error, WeightedIndex}`
- Move `weighted_alias::{AliasableWeight, WeightedAliasIndex}` ->
`weighted::{..}`
- Move `weighted_tree::WeightedTreeIndex` ->
`weighted::WeightedTreeIndex`
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
- Move `Slice` -> `slice::Choose`, `EmptySlice` -> `slice::Empty`
- Rename trait `DistString` -> `SampleString`
- Rename `DistIter` -> `Iter`, `DistMap` -> `Map`
- Move `{Weight, WeightError, WeightedIndex}` -> `weighted::{Weight,
Error, WeightedIndex}`
- Move `weighted_alias::{AliasableWeight, WeightedAliasIndex}` ->
`weighted::{..}`
- Move `weighted_tree::WeightedTreeIndex` ->
`weighted::WeightedTreeIndex`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Re-organise / rename a few things in
rand::distrandrand_distr:Slice->slice::Choose,EmptySlice->slice::EmptyDistString->SampleStringDistIter->Iter,DistMap->Map{Weight, WeightError, WeightedIndex}->weighted::{Weight, Error, WeightedIndex}weighted_alias::{AliasableWeight, WeightedAliasIndex}->weighted::{..}weighted_tree::WeightedTreeIndex->weighted::WeightedTreeIndexMotivation
Some things like
SliceandDistStringweren't that obvious from the name. Now I find the purpose clearer from the path.For
rand_distr, all weighted distributions are now under a single module which is better for doc and shared stuff likeWeight. (Possibly we should go further and move them all to a new crate? But maybe not sincerand::seq::IndexedRandomalso supports weighted sampling.)Possibly more re-organisation of
rand_distris justified. The "flat organisation" system works well enough though.