-
-
Notifications
You must be signed in to change notification settings - Fork 486
Rename Rng => RngExt; bump rand_core to v0.10.0-rc-6
#1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+404
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b1d58c to
79d9026
Compare
newpavlov
approved these changes
Jan 24, 2026
tarcieri
commented
Jan 24, 2026
6bd71c5 to
b7eeedd
Compare
newpavlov
reviewed
Jan 25, 2026
fec5cfa to
70dca8d
Compare
dhardy
requested changes
Jan 25, 2026
Member
|
Could you bump the rand and rand_pcg versions too? |
Contributor
Author
This prerelease of `rand_core` renamed `(Try)RngCore` => `(Try)Rng`. Since `rand` previously defined an `Rng` trait, it now needs a new name, and `RngExt` was the one I saw suggested in rust-random/rand_core#54.
fd1b1d6 to
85161db
Compare
Member
Not necessarily; I'll use the "squash and merge" strategy if commits are messy. |
dhardy
approved these changes
Jan 26, 2026
Member
dhardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prerelease of
rand_corerenamed(Try)RngCore=>(Try)Rng.Since
randpreviously defined anRngtrait, it now needs a new name, andRngExtwas the one I saw suggested in rust-random/rand_core#54.Also bumps:
chacha20v0.10.0-rc.9getrandomv0.4.0-rc.1Added a
CHANGELOG.mdentry