Skip to content

Conversation

@alex-ter
Copy link
Contributor

@alex-ter alex-ter commented Aug 2, 2025

As I didn't get any reply in the discussion, and I see Clippy fixes in the git log, I decided to simply go ahead and submit this one.

Fixes this;

warning: unnecessary use of `get("library_crate").is_none()`
   --> cargo-auditable/tests/it.rs:178:18
    |
178 |     assert!(bins.get("library_crate").is_none());
    |             -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |             |
    |             help: replace it with: `!bins.contains_key("library_crate")`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check

BTW, the test_wasm test fails on master. I haven't looked any deeper into why, but also don't see any open issues for that. Is the failure expected? Would it be helpful if I looked into that?

Signed-off-by: Alex T. <[email protected]>
@Shnatsel
Copy link
Member

Shnatsel commented Aug 2, 2025

The test probably fails because you don't have the webassembly target installed on your system.

@Shnatsel Shnatsel merged commit f2eaf2a into rust-secure-code:master Aug 2, 2025
9 checks passed
@alex-ter alex-ter deleted the alex-ter/clippy-fix branch August 3, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants