Conversation
|
Could @alindima @roypat @rbradford take a look when convenient 🙂 |
alindima
left a comment
There was a problem hiding this comment.
LGTM, but the syscall table validation is failing in the CI for aarch64. is there something wrong with the script? Looks like it's comparing syscall tables of different architectures
Yes, |
|
Can we merge this now @alindima 🙂 for works to be finished in |
|
Hmm, but if you're saying that the script does not for recent kernel versions, how did you generate the tables in the first place? which script did you use? Can you detail a bit what is the problem with the new kernel? Is there a relevant PR in rust-vmm-ci? |
Noted, let me re-organize my code and raise a PR to |
|
@alindima A prototype is available here: rust-vmm/rust-vmm-ci#177, you can verify the generated code through command: rustvmm_gen/rustvmm_gen.py --arch arm64 --version 6.12.8 generate_syscall |
|
Since the validation could take a while to resolve, can I propose to release 0.5.0 of It's blocking our downstream from launching RISC-V support 🥹 |
6d6c8c3 to
afd5d33
Compare
alindima
left a comment
There was a problem hiding this comment.
LGTM, just some nits. Thanks for updating the scripts
Code structure reorganized. Now we need to install headers for each architecture, and extract the syscalls from `unistd_64.h`. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Some of our downstream communities are moving to 6.12 kernel, regenerated `syscall_table` from 6.12 kernel source to catch up. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Update `CHANGELOG.md` and document the update of `syscall_tables` from v6.12 kernel source. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
afd5d33 to
56fe67a
Compare
|
@alindima Thanks for going through the lines, can we merge it and release with 0.5.0 🙂, I will form a release PR later |
Sounds good to me, merged it |
Summary of the PR
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.