This repository was archived by the owner on May 20, 2025. It is now read-only.
vfio_user: fix off-by-one in array bounds checking#33
Merged
rbradford merged 1 commit intorust-vmm:mainfrom Apr 13, 2025
Merged
vfio_user: fix off-by-one in array bounds checking#33rbradford merged 1 commit intorust-vmm:mainfrom
rbradford merged 1 commit intorust-vmm:mainfrom
Conversation
The existing checks didn't catch the case where the other side asked for region/irq n when there are n entries in the vector. This results in ugly crashes like this: thread 'main' panicked at .../vfio-user/src/lib.rs:1082:37: index out of bounds: the len is 0 but the index is 0 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
blitz
requested review from
likebreath,
rbradford,
sameo and
sboeuf
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The existing checks didn't catch the case where the other side asked for region/irq n when there are n entries in the vector. This results in ugly crashes like this:
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.