vhost-device-can: consume desc chain based on rx fifo queue #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiasVara
requested review from
dorindabassey,
epilys,
stefano-garzarella,
stsquad and
vireshk
as code owners
MatiasVara
force-pushed
the
fix-for-923
branch
3 times, most recently
from
8d14d06 to
a7859b2
Compare
Contributor
Author
|
CC @TimosAmpel |
Contributor
Author
|
Due to the changes some tests are not passing, I am working on it. |
Consume descriptor chains from the rx queue based on the size of the reception fifo queue. Before this fix, the device was consuming all available buffers from the rx queue. If the reception fifo queue was shorter than the number of descriptors, those remainder descriptors were lost, i.e., the device was signaling that it used them but they were never returned to the used vring. Some descriptors chains are returned though thus allowing the driver to recycle them. This results in an available ring with less and less descriptors until the vring runs out of descriptors thus blocking the device. Also, break the loop if the rx_fifo queue is empty since there is nothing else to process otherwise the loop is never break since none descriptor is consumed. process_ctrl_requests(), process_tx_requests(), and process_rx_requests() now return true only if the device needs to notify guest, i.e., descriptor chains have been processed and added to used. Fix the tests accordingly. Fixes: rust-vmm#923 Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
MatiasVara
force-pushed
the
fix-for-923
branch
from
a7859b2 to
6552760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Consume descriptor chains from the rx queue based on the size of the reception fifo queue. Before this fix, the device was consuming all available buffers from the rx queue. If the reception fifo queue was shorter than the number of descriptors, those remainder descriptors were lost, i.e., the device was signaling that it used them but they were never returned to the used vring. Some descriptors chains are returned though thus allowing the driver to recycle them. This results in an available ring with less and less descriptors until the vring runs out of descriptors thus blocking the device.
Fixes: #923
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.