Skip to content

Conversation

aesteve-rh
Copy link
Contributor

@aesteve-rh aesteve-rh commented Sep 8, 2023

Summary of the PR

Change uses of master/slave for backend/frontend in the codebase.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR are signed (with git commit -s), and the commit
    message has max 60 characters for the summary and max 75 characters for each
    description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@aesteve-rh aesteve-rh force-pushed the clean-master-slave branch 2 times, most recently from b0ce20f to 73c0184 Compare September 8, 2023 14:34
sboeuf
sboeuf previously approved these changes Sep 11, 2023
Copy link
Collaborator

@sboeuf sboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefano-garzarella
Copy link
Member

I left some minor comments, but it LGTM ;-)

Since it is a breaking change, @jiangliu @eryugey @slp do you have any thought on this?

@aesteve-rh
Copy link
Contributor Author

Since it is a breaking change

Yeah... I can help to update other repositories consuming this API that would be broken after the update.
What would be the best way/order to proceed for those?

@stefano-garzarella
Copy link
Member

stefano-garzarella commented Sep 11, 2023

Yeah... I can help to update other repositories consuming this API that would be broken after the update.

Thanks! Really appreciated!

What would be the best way/order to proceed for those?

I think we need to publish a new release of vhost and vhost-user-backed as a first step. Since both are still 0.y.z, a new y release should be fine since it is a major release. Then we can start to update dependencies like vhost-device's crates, virtiofsd, etc.

Following vhost-user specification, replace
all uses of master/slave with backend/frontend
in the vhost crate.

Signed-off-by: Albert Esteve <[email protected]>
Following vhost-user specification changes,
replace all uses of slave/master with backend/frontend
for the vhost-user-backend crate.

Signed-off-by: Albert Esteve <[email protected]>
@aesteve-rh aesteve-rh requested a review from sboeuf September 12, 2023 14:59
@stefano-garzarella stefano-garzarella merged commit 282a10f into rust-vmm:main Sep 13, 2023
@aesteve-rh
Copy link
Contributor Author

@stefano-garzarella thanks!

I'll keep an eye on the next release and start updating other repositories once available (probably will start with vhost-device, as I already have a fork).

@aesteve-rh aesteve-rh deleted the clean-master-slave branch September 13, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants