Skip to content

Conversation

russell-islam
Copy link
Contributor

@russell-islam russell-islam commented Sep 2, 2024

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@roypat
Copy link
Member

roypat commented Sep 3, 2024

Thanks! It looks like we might be missing some changelog entries, could you add some for #285 and #270 (which is the change we're doing the release for in the first place, haha)

Signed-off-by: Muminul Islam <[email protected]>
@russell-islam
Copy link
Contributor Author

Thanks! It looks like we might be missing some changelog entries, could you add some for #285 and #270 (which is the change we're doing the release for in the first place, haha)

Please take another look now.

Copy link
Member

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@roypat roypat merged commit f0d7af0 into rust-vmm:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants