test: check windows build #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
alexandruag,
bonzini,
jiangliu and
ShadowCurse
as code owners
|
Ah, needs #348 first |
roypat
force-pushed
the
check-windows
branch
from
02b304d to
a0ac6a4
Compare
roypat
added a commit
to roypat/rust-vmm-container
that referenced
this pull request
Sep 27, 2025
Some crates have a myriad of features, and it is very easy to accidentally mess up imports in a way that `cargo check --all-features` works, but only compiling with only a subset of features breaks. For this scenario, cargo check-all-features can help, as it will attempt to compile all feature permutations. We can even add this to the default CI, even for crates like vhost that have incompatible features, due to cargo-all-features allowing the elimination of incompatible features from the test matrix [1]. Some usecases where this could have been helpful is in vm-memory, where we have tens of feature permutations, and some of them invariably get broken regularly [2], or in crates that have no-std support that is offered via an opt-out 'std' feature [3] [1]: https://crates.io/crates/cargo-all-features#options [2]: rust-vmm/vm-memory#350 [3]: rust-vmm/vm-allocator#107 Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
check-windows
branch
2 times, most recently
from
0f8c1aa to
5164ba0
Compare
4 tasks
roypat
added a commit
to rust-vmm/rust-vmm-container
that referenced
this pull request
Sep 30, 2025
Some crates have a myriad of features, and it is very easy to accidentally mess up imports in a way that `cargo check --all-features` works, but only compiling with only a subset of features breaks. For this scenario, cargo check-all-features can help, as it will attempt to compile all feature permutations. We can even add this to the default CI, even for crates like vhost that have incompatible features, due to cargo-all-features allowing the elimination of incompatible features from the test matrix [1]. Some usecases where this could have been helpful is in vm-memory, where we have tens of feature permutations, and some of them invariably get broken regularly [2], or in crates that have no-std support that is offered via an opt-out 'std' feature [3] [1]: https://crates.io/crates/cargo-all-features#options [2]: rust-vmm/vm-memory#350 [3]: rust-vmm/vm-allocator#107 Signed-off-by: Patrick Roy <[email protected]>
bonzini
previously approved these changes
Oct 1, 2025
roypat
force-pushed
the
check-windows
branch
2 times, most recently
from
41f1ed9 to
81819a8
Compare
run `cargo check` for the x86_64-pc-windows-gnu target, to ensure we don't accidentally break building the crate on windows. Hackily add rawfd and xen features to the cargo-all-features denylist for just this test. Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
The tests module in mmap/windows.rs assumed that `crate::bitmap` was always available, but it is not. Hide the imports / usage of that crate behind appropriate cfgs. Fixes: 4757a4a ("do not backdoor-enable backend-bitmap in unittests") Signed-off-by: Patrick Roy <[email protected]>
Otherwise the crate does not compile on windows with --no-default-features --features backend-bitmap (not a particularly useful combination of features, since it gives bitmaps without mmap backends, which would usually drag in the winapi crate, but it should still work). Signed-off-by: Patrick Roy <[email protected]>
the rawfd and xen features do not work on windows (and don't even compile), so explicitly give a compile_error!() in this case. Signed-off-by: Patrick Roy <[email protected]>
stefano-garzarella
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
cargo checkfor the x86_64-pc-windows-gnu target, to ensure we don't accidentally break building the crate on windows.Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.