feat: implement UdpSocket like VsockSocket structure#55
Merged
Conversation
jalil-salame
force-pushed
the
jalil/add-sock-dgram-support
branch
from
6d11354 to
c7828bf
Compare
qwandor
reviewed
Sep 17, 2025
jalil-salame
force-pushed
the
jalil/add-sock-dgram-support
branch
from
00c66f0 to
ad9c480
Compare
This implementation mirrors the stdlib's `UdpSocket` implementation as closely as possible. I skipped some methods to keep the implementation simple, they can be added later if needed. This is ground work for implementing the feature requested in `tokio-vsock`: rust-vsock/tokio-vsock#67 Signed-off-by: Jalil David Salamé Messina <jalil.salame@gmail.com>
Some new lints are firing due to an update to the toolchain, fix them. Signed-off-by: Jalil David Salamé Messina <jalil.salame@gmail.com>
jalil-salame
force-pushed
the
jalil/add-sock-dgram-support
branch
from
ad9c480 to
e5722bc
Compare
Contributor
Author
|
Thanks for the review @qwandor! |
qwandor
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation mirrors the stdlib's
UdpSocketimplementation as closely as possible. I skipped some methods to keep the implementation simple, they can be added later if needed.This is ground work for implementing the feature requested in
tokio-vsock: rust-vsock/tokio-vsock#67