Implement Debug for Context, Surface and Buffer
#268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/context-easier
branch
from
e2d94d0 to
b97e10e
Compare
madsmtm
force-pushed
the
madsmtm/context-easier
branch
from
b97e10e to
831973c
Compare
MarijnS95
approved these changes
Aug 12, 2025
MarijnS95
reviewed
Aug 12, 2025
| @@ -163,6 +166,7 @@ enum Buffer { | |||
| Wire(Vec<u32>), | |||
There was a problem hiding this comment.
Would this print the entire pixel buffer?
There was a problem hiding this comment.
Yeah, I guess so. Might make sense to make a small wrapper struct BufferMinimalDebug(Vec<u32>) to avoid that.
MarijnS95
reviewed
Aug 12, 2025
Comment on lines
+117
to
120
| #[derive(Debug)] | ||
| pub struct BufferImpl<'a, D: ?Sized, W> { | ||
| native_window_buffer: NativeWindowBufferLockGuard<'a>, | ||
| buffer: Vec<u32>, |
There was a problem hiding this comment.
Not sure if we want to spam the user with all pixel values 😅
notgull
requested changes
Aug 13, 2025
|
I do think having that, in addition to perhaps having some platform-specific handle (maybe even just Wayland vs X11) and format should be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #267.