Add Buffer::width and Buffer::height
#269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
commented
Jun 5, 2025
madsmtm
commented
Jun 5, 2025
| @@ -205,6 +205,28 @@ pub struct Buffer<'a, D, W> { | |||
| } | |||
|
|
|||
| impl<D: HasDisplayHandle, W: HasWindowHandle> Buffer<'_, D, W> { | |||
| /// The amount of pixels wide the buffer is. | |||
| pub fn width(&self) -> usize { | |||
There was a problem hiding this comment.
I went with usize here, since it was just much more usable in examples.
I'd like to change resize to follow this direction as well, see:
#238
There was a problem hiding this comment.
I would prefer NonZeroU32 to accurately reflect the type information.
madsmtm
commented
Jun 5, 2025
| @@ -205,6 +205,28 @@ pub struct Buffer<'a, D, W> { | |||
| } | |||
|
|
|||
| impl<D: HasDisplayHandle, W: HasWindowHandle> Buffer<'_, D, W> { | |||
There was a problem hiding this comment.
I'm a bit unsure whether these should go on the buffer or the surface? Or does it make sense both places?
madsmtm
force-pushed
the
madsmtm/width-height
branch
from
6789eff to
344f8b7
Compare
madsmtm
force-pushed
the
madsmtm/width-height
branch
from
344f8b7 to
3f255f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #237.
I've decided to return these in pixels corresponding to the surface/buffer itself, as that's what Softbuffer concerns itself with. If the user wants to render at the current screen DPI, they either need to multiply by a scaling factor themselves, or size the buffer using logical sizes and rely on the compositor to upscale it (which we don't yet expose knobs to control, but which we could in the future).