Remove allocations from the ctru panic hook #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FenrirWolf
force-pushed
the
panic_hook_alloc
branch
from
5438398 to
6308bb2
Compare
FenrirWolf
force-pushed
the
panic_hook_alloc
branch
from
20bf587 to
1cd9437
Compare
FenrirWolf
force-pushed
the
panic_hook_alloc
branch
from
44d297a to
b4ce468
Compare
melody-rs
reviewed
Sep 25, 2025
| use std::fmt::Write; | ||
| use std::sync::{Mutex, TryLockError}; | ||
|
|
||
| static ERROR_CONF: Mutex<errorConf> = unsafe { Mutex::new(std::mem::zeroed()) }; |
There was a problem hiding this comment.
imo this static should be exposed somewhere so other users of ctru-rs can use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the panic hook so that it creates the error app config ahead of time and then performs no further allocations upon invocation. Or at least no extra allocations on the
ctru-rsside of things; no idea if there are extra allocations that happen when calling the applet or unwinding the stack, but we don't have control over those things anyway.