[cc] array param qualifiers #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for C99 array parameter qualifiers, enabling the parser to handle static, const, volatile, and restrict keywords in array parameter declarations, as well as the VLA unspecified size notation [*].
Key Changes:
- Parser enhancement to recognize and handle array parameter qualifiers (static, const, volatile, restrict) per C99 6.7.5.3
- Implementation of VLA
[*]syntax with proper disambiguation from pointer dereference expressions - Comprehensive test suite covering all qualifier combinations and edge cases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cc/tests/features/mod.rs | Registers the new array_param_qualifiers test module |
| cc/tests/features/array_param_qualifiers.rs | Adds 9 comprehensive tests covering static, const, volatile, restrict qualifiers, combined qualifiers, VLA [*] syntax, and edge cases like expressions with multiplication and pointer dereferencing |
| cc/parse/parser.rs | Extends parse_parameter_list to parse array parameter qualifiers and VLA [*] syntax, converts array parameters to qualified pointers per C99 specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.