Xgettext merge #448
Merged
Xgettext merge #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR merges #403, which adds xgettext functionality to extract translatable strings from source code and generates .pot (Portable Object Template) files for internationalization. The PR also includes locale file generation for multiple languages and updates build tooling.
Key changes:
- Implements a new
xgettextutility in Rust that extractsgettextcalls from Rust source files - Generates
.potemplate files for 6 languages (ru, pt, ja, hi, es, bn) with 1246 message entries each - Updates build system with a Makefile for locale file generation and management
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| i18n/xgettext.rs | New xgettext implementation for extracting translatable strings from Rust code |
| i18n/tests/xgettext/* | Comprehensive test suite for xgettext functionality |
| locale/*/LC_MESSAGES/posixutils-rs.po | Generated locale template files for 6 languages |
| process/timeout.rs | Changed em dash (—) to regular hyphen (-) in help text |
| i18n/iconv.rs | Changed em dash (—) to regular hyphen (-) in help text |
| i18n/Cargo.toml | Added dependencies for xgettext (proc-macro2, quote, syn) |
| Makefile | New build system for locale file generation |
| .gitignore | Added locale build artifacts to gitignore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of #403