New util: lp #481
Merged
New util: lp #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX Compliance Fixes: 1. -m option - Now accepted as stub (was returning error) 2. -w option - Now accepted as stub (was returning error) Code Cleanup: 3. -c handling - Removed unused copy_mode parameter from read_input() function. Added comment explaining that copy mode is effectively always-on due to IPP requirements. Files Modified: - print/lp.rs - Main implementation - print/tests/lp/mod.rs - Updated tests
There was a problem hiding this comment.
Pull request overview
This PR implements a new lp utility for sending files to a printer using the Internet Printing Protocol (IPP). The implementation follows POSIX.2024 compliance and includes comprehensive error handling and test coverage.
- Implements the core
lpcommand with support for IPP protocol printers - Adds command-line options for destination, copies, silent mode, title, and printer-dependent options
- Includes 8 integration tests covering error cases, environment variable handling, and option parsing
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| print/lp.rs | Main implementation of the lp utility with IPP client functionality |
| print/tests/lp/mod.rs | Integration tests for lp utility covering various scenarios and error conditions |
| print/tests/print-tests.rs | Test harness entry point that imports the lp test module |
| print/Cargo.toml | Package configuration with minimal dependencies (ipp, clap, gettext-rs, num-traits) |
| Cargo.toml | Workspace update adding the print crate as a member |
| Cargo.lock | Dependency lock file updates for new IPP-related dependencies |
| lib/utils.tsv | Registry update adding lp to the utilities list |
| README.md | Documentation update marking lp as completed and moving it from misc category |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.