-
Notifications
You must be signed in to change notification settings - Fork 39
[Tooling] multiline rationale and improved reproducible build justification #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manczak-ifx
wants to merge
1
commit into
rustfoundation:main
Choose a base branch
from
manczak-ifx:update-comp-features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -28,8 +28,10 @@ topics: | |||||||||
| description: "Stack buffer overflow detection and protection mechanism" | ||||||||||
| priority: "High" | ||||||||||
| status: "Missing" | ||||||||||
| category: "Security" | ||||||||||
| rationale: "Stack protection is not available in any Rust compiler, but required for runtime stack overflow detection in safety-critical systems" | ||||||||||
| category: ["Security"] | ||||||||||
| rationale: > | ||||||||||
| Stack protection is not available in any Rust compiler, but required for runtime stack overflow detection in | ||||||||||
| safety-critical systems | ||||||||||
| related-links: | ||||||||||
| - "https://developer.arm.com/documentation/dui0774/l/Compiler-Command-line-Options/-fstack-protector---fstack-protector-all---fstack-protector-strong---fno-stack-protector" | ||||||||||
| - "https://github.com/rust-lang/rust/issues/114903" | ||||||||||
|
|
@@ -38,8 +40,10 @@ topics: | |||||||||
| description: "TrustZone support for ARM Cortex-M processors" | ||||||||||
| priority: "High" | ||||||||||
| status: "Nightly" | ||||||||||
| category: "Security" | ||||||||||
| rationale: "TrustZone support is available only on nightly Rust. Stabilizing it is required for data sagmentation on cortex-m devices" | ||||||||||
| category: ["Security"] | ||||||||||
| rationale: > | ||||||||||
| TrustZone support is available only on nightly Rust. Stabilizing it is required for data sagmentation on cortex-m | ||||||||||
| devices | ||||||||||
| related-links: | ||||||||||
| - "https://developer.arm.com/documentation/100690/latest/" | ||||||||||
| - "https://github.com/rust-lang/rust/issues/81391" | ||||||||||
|
|
@@ -49,27 +53,38 @@ topics: | |||||||||
| description: "Control flow integrity protection against ROP/JOP attacks" | ||||||||||
| priority: "Medium" | ||||||||||
| status: "Partial" | ||||||||||
| category: "Security" | ||||||||||
| rationale: "Prevents control flow hijacking attacks in safety-critical applications. Currently limited CFI support, not comprehensive for all control flow transfers" | ||||||||||
| category: ["Security"] | ||||||||||
| rationale: > | ||||||||||
| Prevents control flow hijacking attacks in safety-critical applications. Currently limited CFI support, not | ||||||||||
| comprehensive for all control flow transfers | ||||||||||
| related-links: | ||||||||||
| - "https://clang.llvm.org/docs/ControlFlowIntegrity.html" | ||||||||||
| - "https://github.com/rust-lang/rust/issues/89653" | ||||||||||
|
|
||||||||||
| - name: "Deterministic Code Generation" | ||||||||||
| - name: "Reproducible Build" | ||||||||||
| description: "Reproducible binary output for certification requirements" | ||||||||||
| priority: "High" | ||||||||||
| status: "Partial" | ||||||||||
| category: "Safety" | ||||||||||
| rationale: "Not fully deterministic across different build environments. Required for certification processes that mandate reproducible builds" | ||||||||||
| category: ["Safety", "Security"] | ||||||||||
| rationale: > | ||||||||||
| ISO 26262 Part 7 Section 7.4.4 mentions the workproducts need to be reproducable throughout the product lifecycle. | ||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| ISO/SAE 21434 requires supply chain security and software integrity verification - reproducible builds enable | ||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| independent verification that binaries match source code and detect unauthorized modifications in the build pipeline. | ||||||||||
| Current Rust builds can vary based on environment, timestamps, etc. Other security standards also require reproducible | ||||||||||
| builds, see links. | ||||||||||
| related-links: | ||||||||||
| - "https://github.com/rust-lang/rust/issues/34902" | ||||||||||
| - "https://github.com/rust-lang/rust/issues/129080" | ||||||||||
| - "https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-218.pdf" | ||||||||||
| - "https://www.bsi.bund.de/SharedDocs/Downloads/EN/BSI/Publications/TechGuidelines/TR03185/BSI-TR-03185.pdf?__blob=publicationFile&v=4" | ||||||||||
| - "https://slsa.dev/spec/v1.2/build-provenance" | ||||||||||
|
|
||||||||||
| - name: "Coverage Instrumentation for Macros" | ||||||||||
| description: "Code coverage that includes macro expansions" | ||||||||||
| priority: "High" | ||||||||||
| status: "Missing" | ||||||||||
| category: "Safety" | ||||||||||
| rationale: "Coverage tools cannot instrument macro-generated code. Complete coverage analysis required for safety certification" | ||||||||||
| rationale: > | ||||||||||
| Coverage tools cannot instrument macro-generated code. Complete coverage analysis required for safety certification | ||||||||||
| related-links: | ||||||||||
| - "https://github.com/rust-lang/rust/issues/79417" | ||||||||||
|
|
||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.