Merged
Conversation
I went to do this work and then realized we need unreleased support for tree-sitter 0.24 in tree-sitter-md before we can start on this. Add a note for clarity.
Member
Author
|
@ctz Do you have time to give this a +1? Also open to feedback that it's not worth the trouble. |
ctz
approved these changes
Jan 22, 2025
Adds a tiny Makefile that defers to `cargo capi install`. Previously rustls-ffi offered a GNU `Makefile` for building the library on Linux/MacOS. Because of the inherent limitations of this build system and a desire to have uniformity across all supported operating systems we've replaced this with usage of `cargo-c`. While the README documents the finer details of using `cargo-c` it's likely some users just want to keep doing what they were doing before: running `make install` with a custom `DESTDIR`. This commit provides a shortcut to do just that, backed by `cargo-c`. I have explicitly not restored the ability to: * build/run the client/server tests: this is handled by `cmake` now. * handle developer tasks like formatting/linting. Also handled by `cmake` now. * customize the build (e.g. debug build, alt crypto providers, fips mode, etc). use cargo-c directly for this per the README instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tiny Makefile that defers to
cargo capi install.Previously rustls-ffi offered a GNU
Makefilefor building the library on Linux/MacOS. Because of the inherent limitations of this build system and a desire to have uniformity across all supported operating systems we've replaced this with usage ofcargo-c.While the README documents the finer details of using
cargo-cit's likely some users just want to keep doing what they were doing before: runningmake installwith a customDESTDIR.This commit provides a shortcut to do just that, backed by
cargo-c. I have explicitly not restored the ability to:cmakenow.cmakenow.cargo-cdirectly for this per the README instructions.Resolves #525