Skip to content

docgen: skip over cpp attributes before decl #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctz merged 1 commit into from
Jul 8, 2025
Merged

docgen: skip over cpp attributes before decl #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tools/src/bin/docgen/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,16 @@ fn comment_and_requirement(
node: Node,
src: &[u8],
) -> Result<(Option<Comment>, Option<Feature>), Box<dyn Error>> {
let maybe_comment = Comment::new(node, src).ok();
let mut maybe_comment = Comment::new(node, src).ok();

// If node wasn't a comment, see if it was an expression_statement
// that itself was preceded by a comment. This skips over
// expression-like preprocessor attributes on function decls.
if let (None, "expression_statement", Some(prev)) =
(&maybe_comment, node.kind(), node.prev_sibling())
{
maybe_comment = Comment::new(prev, src).ok();
}

// If prev wasn't a comment, see if it was a feature requirement.
if maybe_comment.is_none() {
Expand Down
Loading