Skip to content

Use CRL by default instead of OCSP on android #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use CRL by default instead of OCSP on android #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...rustls-platform-verifier/src/main/java/org/rustls/platformverifier/CertificateVerifier.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,9 @@ internal object CertificateVerifier {

revocationChecker.options = EnumSet.of(
PKIXRevocationChecker.Option.SOFT_FAIL,
PKIXRevocationChecker.Option.ONLY_END_ENTITY
PKIXRevocationChecker.Option.ONLY_END_ENTITY,
PKIXRevocationChecker.Option.PREFER_CRLS,
PKIXRevocationChecker.Option.NO_FALLBACK
Comment on lines +334 to +335
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As some immediate feedback, nonwithstanding the newly posted information about Android's internal behavior, this part would need to be gated behind if (!BuildConfig.TEST) in order to support our tests that validate stapled OCSP data.

Despite OCSP going on its way out I don't think the tests are removable yet because its stable-ish behavior and I don't see a reason to completely drop them yet.

)

// Use the OCSP data `rustls` provided, if present.
Expand Down
Loading