Report incorrect group information in users#2190
Merged
djc merged 1 commit intorustsec:mainfrom Jun 3, 2025
danth:patch-1
Merged
Report incorrect group information in users#2190djc merged 1 commit intorustsec:mainfrom danth:patch-1
users#2190djc merged 1 commit intorustsec:mainfrom
danth:patch-1
Conversation
riking
reviewed
Mar 21, 2025
djc
reviewed
Jun 2, 2025
djc
reviewed
Jun 3, 2025
| Versions older than 0.8.0 do not contain the affected functions, so downgrading | ||
| to them is a workaround. | ||
|
|
||
| ## Recommended alternatives |
Member
There was a problem hiding this comment.
Sorry, I think we have to be a bit careful in our wording here. Suggest to replace "Recommended" with "Potential".
(Also, would be nice to add an empty line after the section title.)
Contributor
Author
There was a problem hiding this comment.
This section was copied word-for-word from the previous report on users
Member
|
@danth thanks for your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already documented in ogham/rust-users#44 regarding listing the groups for the current process. However, this also affects listing the supplementary groups for a particular user.
I discovered this while implementing a file server which controls access based on the underlying filesystem permissions. If the file in question was owned by the
rootgroup, then it would inadvertently be accessible to everyone, as they are believed to be a member of that group.There may be other applications out there doing something similar, hence I think it's important to raise this as a security issue and not just a general bug.
The boundary for the affected versions is based on this commit and this commit, where the functionality was first introduced.