Skip to content

add unsoundness of indradb-lib #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add unsoundness of indradb-lib #2197

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8152fbc
add unsoundness of indradb-lib
shinmao Jan 18, 2025
d5ef09e
affected functions in indradb-lib
shinmao Jan 18, 2025
4fc535a
affected functions in indradb-lib
shinmao Jan 18, 2025
dc783be
affected functions in indradb-lib
shinmao Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions crates/indradb-lib/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "indradb-lib"
date = "2025-01-18"
url = "https://github.com/indradb/indradb/issues/317"
categories = ["memory-corruption"]
keywords = ["out-of-bounds"]

[versions]
patched = [">= 4.0.0"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, only version 5.0.0 and up have been patched, not 4.0.0+.

unaffected = ["< 3.0.0"]

[affected.functions]
"indradb_lib::util::read_identifier" = [
">= 3.0.0, < 4.0.0",
]
```

# Unsound `read_identifier`
The function incorrectly assumes that any `T` could be legal `u8`, then could be used to create legal string with utf8-encoding, causing to out-of-bounds.

The function is patched by making it `unsafe`, asking user to guarantee the correctness and safety of input before calling the API (commit `4773393`).
Loading