c10::optional -> std::optional #394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nov 29, 2023, PyTorch's
c10::optionalhas been an alias forstd::optional(link).As of Dec 17, 2024, PyTorch has begun taking steps to begin removing the
c10::optionalalias entirely (link). The old API remains available, for now, but you can check whether your code has eliminated all instances of deprecated APIs by compiling withC10_NODEPRECATEDdefined as a preprocessor flag (-DC10_NODEPRECATED).This PR converts your existing usages of
c10::optionaltostd::optional(same fornullopt).(Additional deprecated APIs include
C10_UNUSED,C10_NODISCARD, andc10::string_view.)