Pass builtInOnly parameter correctly for list types

[shahinataei-ts]

Summary

• Fix incorrect parameter passing in mapGraphQLTypeToPHPType for ListOfType

Problem

When processing ListOfType, the $builtInOnly parameter was passed as the second argument ($nullable) instead of the third argument ($builtInOnly):

// Before (bug)
return SymfonyType::list($this->mapGraphQLTypeToPHPType($type->getWrappedType(), $builtInOnly));

// After (fix)
return SymfonyType::list($this->mapGraphQLTypeToPHPType($type->getWrappedType(), null, $builtInOnly));

This caused $builtInOnly to default to false, resulting in the PHP mapped type being used instead of the primitive JSON type in $data parameter docblocks.

Example

// Config
->withScalar('Currency', Type::string(), Type::object(Currency::class))

// GraphQL: currencies: [Currency!]!

// Generated (wrong):  'currencies': list<Currency>
// Should be:          'currencies': list<string>

PHPStan Error

This bug caused PHPStan errors in generated code:

Parameter #1 $code of class Money\Currency constructor expects non-empty-string, Money\Currency given.

Affected Types

Any custom scalar where the primitive type differs from the PHP type, when used in a list:

• [Currency!]! (string → Money\Currency)
• [DateTime!]! (string → DateTimeImmutable)
• [Country!]! (string → Country enum)

[ruudk]

Thanks!