-
Notifications
You must be signed in to change notification settings - Fork 352
Feat(heuristics): Add optional weights feature toggle in settings #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rakshityadav1868
wants to merge
1
commit into
ruxailab:develop
Choose a base branch
from
rakshityadav1868:adding-weight-toggle-btn
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -20,7 +20,9 @@ | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <v-tab>{{ $t('HeuristicsEditTest.titles.heuristics') }}</v-tab> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <v-tab>{{ $t('HeuristicsEditTest.titles.options') }}</v-tab> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <v-tab>{{ $t('HeuristicsEditTest.titles.weights') }}</v-tab> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <v-tab v-if="showWeightsTab">{{ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| $t('HeuristicsEditTest.titles.weights') | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }}</v-tab> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <v-tab v-if="showSettingsTab">{{ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| $t('HeuristicsEditTest.titles.settings') | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }}</v-tab> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -57,12 +59,12 @@ | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @change="change = true" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| /> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <WeightTable | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| v-if="index == 2" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| v-if="showWeightsTab && index == 2" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| :is-template="isTemplate" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @change="change = true" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| /> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <HeuristicsSettings | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| v-if="showSettingsTab && index == 3" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| v-if="showSettingsTab && (showWeightsTab ? index == 3 : index == 2)" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| :is-template="isTemplate" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| :is-template="isTemplate" | |
| :is-template="isTemplate" | |
| @change="change = true" |
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In template preview mode, showWeightsTab is derived solely from test.useWeights. The template preview payload currently provides testWeights but not useWeights, so weights will never be shown in the preview even if the template contains weights. Either include useWeights in the template payload or derive the preview visibility from existing data (e.g., non-empty testWeights) / default to showing weights for templates.
Suggested change
| const showWeightsTab = computed(() => test.value.useWeights ?? false) | |
| const showWeightsTab = computed(() => { | |
| if (props.isTemplate) { | |
| const weights = props.templateTest?.testWeights | |
| if (Array.isArray(weights)) { | |
| return weights.length > 0 | |
| } | |
| return !!weights | |
| } | |
| return test.value?.useWeights ?? false | |
| }) |
Comment on lines
+148
to
+157
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The watcher only corrects the active tab when weights are disabled. If weights are enabled while the user is on Settings (index 2 when weights are hidden), the current index will now point to the Weights tab and the UI will unexpectedly jump away from Settings. Consider updating the watcher to also handle the false→true transition (and generally clamp index to the highest available tab based on showWeightsTab/showSettingsTab).
Suggested change
| // Watch for changes in showWeightsTab to fix index | |
| watch(showWeightsTab, (newVal, oldVal) => { | |
| // If weights tab visibility changed and we're currently on or past the weights tab | |
| if (newVal !== oldVal) { | |
| if (!newVal && index.value > 1) { | |
| // Weights tab is now hidden and index is on Settings (was 3, should be 2) | |
| index.value = 2 | |
| } | |
| } | |
| }) | |
| // Watch for changes in tab visibility to keep the active index valid | |
| watch( | |
| [showWeightsTab, showSettingsTab], | |
| ([weightsVisible, settingsVisible], [oldWeightsVisible]) => { | |
| // Handle the case where weights are enabled while the user is on Settings. | |
| // When weights are hidden, SETTINGS has index 2; when weights are shown, | |
| // WEIGHTS becomes 2 and SETTINGS moves to 3. If we don't adjust here, | |
| // the user would unexpectedly jump from SETTINGS to WEIGHTS. | |
| if (!oldWeightsVisible && weightsVisible && settingsVisible && index.value === 2) { | |
| index.value = 3 | |
| return | |
| } | |
| // In all cases, clamp the index to the highest available tab based on visibility. | |
| let maxIndex = 1 // HEURISTICS (0) and OPTIONS (1) are always present | |
| if (weightsVisible) { | |
| maxIndex = 2 | |
| } | |
| if (settingsVisible) { | |
| maxIndex = weightsVisible ? 3 : 2 | |
| } | |
| if (index.value > maxIndex) { | |
| index.value = maxIndex | |
| } | |
| } | |
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toggling useWeights commits to Vuex but doesn’t notify the parent view that there are unsaved changes, so the toggle can’t be persisted unless the user edits something else first. Consider emitting a
changeevent (or otherwise setting the parent’schangeflag) from this setter / switch update handler.