fix(e2e): replace hardcoded URLs with Playwright baseURL configuration by aaradhychinche-alt · Pull Request #1842 · ruxailab/RUXAILAB

aaradhychinche-alt · 2026-03-08T08:15:21Z

Summary

This PR replaces hardcoded URLs in Playwright tests with relative paths and configures baseURL in the Playwright configuration.

Previously, some tests used absolute URLs such as:

await page.goto('http://localhost:8080/signin')

This makes the tests environment-specific and harder to run in CI or staging environments.

With this change, tests now use relative paths while relying on Playwright's baseURL configuration.

Changes

Added baseURL configuration in playwright.config.js
Replaced hardcoded URLs like:
- http://localhost:8080/signin
- http://localhost:8080/
Updated navigation calls to use relative paths:
- /signin
- /

Example:

Before

await page.goto('http://localhost:8080/signin')

After

await page.goto('/signin')

Benefits

Tests can run against different environments (local, CI, staging)
Removes environment-specific assumptions
Improves maintainability of Playwright tests

Screenshots / Media

Before

Tests used hardcoded navigation URLs:

await page.goto('http://localhost:8080/signin')

After

Tests now rely on the configured baseURL:

await page.goto('/signin')

Testing

Verified Playwright tests run locally with the configured baseURL
CI checks pass successfully

Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>

… wait strategy - playwright.config.ts was the active config (takes priority over .js) but had baseURL commented out, causing 'Cannot navigate to invalid URL' for all relative paths. Uncomment and set to process.env.BASE_URL || 'http://localhost:8080'. - playwright.config.js: remove redundant ...devices['Desktop Chrome'] spread from the global use block (device presets belong only inside each project entry). Add explanatory comments on baseURL and project inheritance. - e2e/createHeuristicTest.spec.js: replace waitUntil: 'networkidle' with 'domcontentloaded' + explicit waitFor on the Email field. Firebase keeps persistent WebSocket connections open so networkidle never resolves on this app. Pass testInfo to logIn() and log testInfo.project.use.baseURL for debugging. Fixes: relative page.goto('/signin') calls introduced in the URL refactor. Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>

Copilot

Pull request overview

This PR aims to make Playwright E2E tests environment-agnostic by configuring a Playwright baseURL and switching test navigation from hardcoded absolute URLs to relative paths.

Changes:

Set baseURL in Playwright config (with env override).
Replace page.goto('http://localhost:8080/...') with page.goto('/...') across several E2E specs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
playwright.config.js	Adds env-driven `baseURL` to support relative navigation in tests.
e2e/template_testing.spec.ts	Updates navigation to use `/` instead of hardcoded localhost URL.
e2e/signIntest.spec.js	Updates Sign In navigation to use `/signin` relative path.
e2e/ruxailabtest.spec.js	Updates Sign In navigation to use `/signin` relative path.
e2e/createHeuristicTest.spec.js	Updates Sign In navigation to use `/signin` relative path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-08T08:18:47Z

playwright.config.js

+    /* Base URL so relative paths like page.goto('/signin') resolve correctly.
+       Override by setting BASE_URL env var, e.g. BASE_URL=https://staging.example.com */
+    baseURL: process.env.BASE_URL || 'http://localhost:8080',


playwright test is invoked without --config, and this repo contains both playwright.config.ts and playwright.config.js (Dockerfile-playwright copies both). If Playwright resolves the TS config by default, baseURL from this JS file won’t be applied and page.goto('/...') will fail. To avoid ambiguous/incorrect config selection, either move this baseURL setting into the config file that’s actually used (likely playwright.config.ts), or remove/rename the unused config so only one default config exists.

Suggested change

/* Base URL so relative paths like page.goto('/signin') resolve correctly.

Override by setting BASE_URL env var, e.g. BASE_URL=https://staging.example.com */

baseURL: process.env.BASE_URL || 'http://localhost:8080',

Copilot · 2026-03-08T08:18:48Z

playwright.config.js

  use: {
-    baseURL: devBaseUrl,
-    ...devices['Desktop Chrome'],
+    /* Base URL so relative paths like page.goto('/signin') resolve correctly.


Using process.env.BASE_URL here is easy to confuse with Vue CLI’s BASE_URL (often set to a public path like /). If that env var is present when running Playwright, it can produce an invalid baseURL. Consider switching to a more specific env var (e.g. PLAYWRIGHT_BASE_URL/E2E_BASE_URL) and/or validating that it’s a full origin URL (scheme + host).

Copilot · 2026-03-08T08:18:48Z

playwright.config.js

  use: {
-    baseURL: devBaseUrl,
-    ...devices['Desktop Chrome'],
+    /* Base URL so relative paths like page.goto('/signin') resolve correctly.


The default fallback here is http://localhost:8080, but the repo’s Dockerfile-playwright serves the app on port 5000 and runs npx playwright test without setting a base URL. If that Docker workflow is expected to work, the fallback should align with the served port or the Docker command should export the env var used here.

…x SonarCloud duplication Introduce a typed baseUse constant that holds the single definition of baseURL. Spread it into both the global use block and each project's use block so the string literal 'process.env.BASE_URL || http://localhost:8080' appears exactly once in the file, eliminating the duplicated-new-code finding in SonarCloud. Also remove commented-out boilerplate (mobile/branded browser projects, dotenv import, webServer block) that inflated the scanned line count and contributed to the duplication percentage on new code. Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>

…etition Replace three hand-written project objects with a typed browserProjects tuple array and a single projects.map() callback. The use-block shape { ...baseUse, ...device } is now written exactly once instead of three times, removing the structural duplication that SonarCloud flagged on new code. Adding or removing a browser now requires a single line in browserProjects rather than copying an entire project block. Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-08T08:34:03Z

playwright.config.ts

@@ -1,81 +1,47 @@
-import { defineConfig, devices } from '@playwright/test'
+import { defineConfig, devices, PlaywrightTestOptions } from '@playwright/test'


PlaywrightTestOptions is only used as a type here, but it’s imported as a runtime value. Consider switching this to a type-only import (or using type PlaywrightTestOptions in the import) to avoid carrying an unnecessary runtime import and to prevent issues if the config is ever loaded in ESM mode.

Suggested change

import { defineConfig, devices, PlaywrightTestOptions } from '@playwright/test'

import { defineConfig, devices, type PlaywrightTestOptions } from '@playwright/test'

Copilot · 2026-03-08T08:34:04Z

playwright.config.ts

+ * Shared base options spread into the global use block and every project.
+ * Defined once here — the single source of truth that SonarCloud checks.
+ *


This file’s header comment says it is the “single source of truth”, but the repo also maintains a parallel playwright.config.js with overlapping settings (including baseURL). That duplication makes it easy for the two configs to drift; consider consolidating into a single Playwright config or updating test scripts/CI to explicitly select one config via --config so there’s a clear source of truth.

Suggested change

* Shared base options spread into the global use block and every project.

* Defined once here — the single source of truth that SonarCloud checks.

*

* Shared base options for this Playwright config, spread into the global

* use block and every project defined below.

*

* Keep this in sync with any other Playwright config files (for example,

* playwright.config.js) so that settings like baseURL do not drift.

Copilot · 2026-03-08T08:34:04Z

e2e/createHeuristicTest.spec.js

 // --- Reusable login function ---
-const logIn = async (page) => {
+const logIn = async (page, testInfo) => {
+  console.log('Base URL:', testInfo.project.use.baseURL);


The new console.log('Base URL:', ...) will add noise to test output and can leak environment details in CI logs. Consider removing it or gating it behind an explicit debug flag (e.g., an env var) so it’s only printed when troubleshooting.

Suggested change

console.log('Base URL:', testInfo.project.use.baseURL);

if (process.env.E2E_DEBUG_BASE_URL === 'true') {

console.log('Base URL:', testInfo.project.use.baseURL);

}

Extract three repeated code sequences into named helper functions: - login(page): signs in via /signin using the shared test account. Replaces the 4-line block repeated verbatim in every test. - goToPersonalTemplates(page): clicks Templates then Personal tab. Replaces the 2-line block repeated in every test. - openNewUserTestDialog(page): clicks create-test-btn, selects 'Create a blank test' > 'Testing' > 'Webcam, audio & screen record'. Replaces the 4-line block repeated in 4 of the 5 tests. All tests are wrapped in test.describe with beforeEach calling login() so sign-in runs once per test without repetition in test bodies. No assertions or test logic changed. Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>

sonarqubecloud · 2026-03-08T08:38:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

aaradhychinche-alt · 2026-03-08T09:44:56Z

@marcgc21 ready to be reviewed !!!

aaradhychinche-alt · 2026-03-14T07:09:06Z

@KarinePistili can You review this once when you have time ? ! Thank You !

fix(e2e): replace hardcoded URLs with Playwright baseURL configuration

832b3f2

Signed-off-by: Aaradhy Chinche <aaradhychinche@gmail.com>

Copilot AI review requested due to automatic review settings March 8, 2026 08:15

github-actions bot added fix medium-complexity size/S testing labels Mar 8, 2026

Copilot started reviewing on behalf of aaradhychinche-alt March 8, 2026 08:15 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

github-actions bot added size/M and removed size/S labels Mar 8, 2026

Copilot AI review requested due to automatic review settings March 8, 2026 08:30

Copilot started reviewing on behalf of aaradhychinche-alt March 8, 2026 08:30 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(e2e): replace hardcoded URLs with Playwright baseURL configuration#1842

fix(e2e): replace hardcoded URLs with Playwright baseURL configuration#1842
aaradhychinche-alt wants to merge 5 commits intoruxailab:developfrom
aaradhychinche-alt:fix/playwright-baseurl

aaradhychinche-alt commented Mar 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

sonarqubecloud bot commented Mar 8, 2026

Uh oh!

aaradhychinche-alt commented Mar 8, 2026

Uh oh!

aaradhychinche-alt commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/* Base URL so relative paths like page.goto('/signin') resolve correctly.
	Override by setting BASE_URL env var, e.g. BASE_URL=https://staging.example.com */
	baseURL: process.env.BASE_URL \|\| 'http://localhost:8080',

		@@ -1,81 +1,47 @@
		import { defineConfig, devices } from '@playwright/test'
		import { defineConfig, devices, PlaywrightTestOptions } from '@playwright/test'

	import { defineConfig, devices, PlaywrightTestOptions } from '@playwright/test'
	import { defineConfig, devices, type PlaywrightTestOptions } from '@playwright/test'

- * Shared base options spread into the global use block and every project.
- * Defined once here — the single source of truth that SonarCloud checks.
- *
+ * Shared base options for this Playwright config, spread into the global
+ * use block and every project defined below.
+ *
+ * Keep this in sync with any other Playwright config files (for example,
+ * playwright.config.js) so that settings like baseURL do not drift.

Conversation

aaradhychinche-alt commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Benefits

Screenshots / Media

Before

After

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 8, 2026

Quality Gate passed

Uh oh!

aaradhychinche-alt commented Mar 8, 2026

Uh oh!

aaradhychinche-alt commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aaradhychinche-alt commented Mar 8, 2026 •

edited

Loading