fix: use answersDocId instead of testDocId when deleting answer document#1867
Open
Karrrthik7 wants to merge 1 commit intoruxailab:developfrom
Open
fix: use answersDocId instead of testDocId when deleting answer document#1867Karrrthik7 wants to merge 1 commit intoruxailab:developfrom
Karrrthik7 wants to merge 1 commit intoruxailab:developfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1861
Problem
The
removeUserAnswermethod inAnswerControllerwas deleting the wrong Firestore document.The code previously used:
userToUpdate.myAnswers[payload.testDocId].testDocIdHowever,
testDocIdrepresents the study identifier, not the Firestore document ID of the answer.The
UserAnswermodel stores two fields:testDocId→ study identifieranswersDocId→ Firestore document ID in theanswerscollectionBecause of this mismatch, the system attempted to delete:
answers/{testDocId}instead of the actual answer document:
answers/{answersDocId}This left orphaned answer documents in Firestore when a cooperator was removed.
Solution
The deletion now uses
answersDocIdinstead oftestDocId:This ensures the correct document in the answers collection is deleted.
Impact
Files Changed: src/shared/controllers/AnswerController.js
Screenshots