Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #94
Pull Request: Fix Model Selection Dropdown Variable Conflict
PR Title
Fix v-select variable conflict in Model Selection dropdown
Type of Change
Description
This PR fixes a critical bug in the Model Selection dropdown where
v-modeland:itemswere bound to the same variable, causing type errors and breaking the dropdown functionality.Problem
The
v-selectcomponent inMiscConfigCard.vuehad bothv-modeland:itemsbound to the samemodelsvariable. This created a conflict where selecting a model would overwrite the items array with a string value, causing Vue to throw a type error and breaking the dropdown.Solution
Separated the single
modelsvariable into two distinct variables:selectedModel: Holds the currently selected model valuemodelOptions: Holds the array of available model optionsThis ensures the dropdown items remain intact while allowing the selected value to change independently.
Changes Made
Modified Files
src/components/calibration/MiscConfigCard.vueDetailed Changes
1. Updated Template (Line 24)
Before:
After:
2. Updated Data Properties (Lines 36-43)
Before:
After:
3. Updated Watcher (Lines 52-54)
Before:
After:
Testing
Before Fix
[Vue warn]: Invalid prop: type check failed for prop "items". Expected Array, got StringAfter Fix
Related Issues
Fixes issue documented in `ISSUE_MODEL_SELECTION_VSELECT.md
Screenshots
Before Fix:-
https://github.com/user-attachments/assets/6ff1ca1d-1684-475d-bad3-56bfd9307fa4
After fix:-
AfterFixEyeTracker.mp4
Checklist