Dynamically detect rbp offset used in GetRbp#716
Merged
Conversation
In case the detection fails, fallback to the previous value of 1 long as the previous code used + 1 to actually mean 8 bytes. If something does go wrong with the detection, dump the code of the whole method to help debug.
notfood
added
enhancement
Member
|
Need testing on Mac. Works fine under Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case the detection fails, fallback to the previous value of 1 long as the previous code used + 1 to actually mean 8 bytes. If something does go wrong with the detection, dump the code of the whole method to help debug.
Needs more testing to make sure it works correctly across different machines.
Tested with the save file from #658 (comment)
Related: #562, #662