-
Notifications
You must be signed in to change notification settings - Fork 24
TransformAndMapHuggingFaceDatasetJob and ExtractTextFromHuggingFaceDatasetJob #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
albertz
wants to merge
17
commits into
main
Choose a base branch
from
albert-hf-convert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7fe8057
TransformAndMapHuggingFaceDatasetJob
albertz f7bee40
better sharding
albertz 841b9e2
small fix
albertz 3d9b51f
ExtractTextFromHuggingFaceDatasetJob
albertz 1750732
more
albertz d59b448
cleanup
albertz 0a1482b
more
albertz 75425a2
better
albertz db4f560
better
albertz 211cd49
support loading existing dataset via load_from_disk
albertz 1e50b2a
support loading existing dataset via load_from_disk fix
albertz b846858
more
albertz 927091a
better
albertz 0f2bde4
max_shard_size fixed default
albertz cafaf2f
doc
albertz 5f88c54
doc
albertz 0c6ea2b
comment on tmp dir
albertz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per the discussion in rwth-i6/sisyphus#274, should we do a copy here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, my comment from there (rwth-i6/sisyphus#274 (comment)):
The (shallow) copy on
kwargswould need to be done anyway inJobSingleton.__call__if we want to fix rwth-i6/sisyphus#274. So then modifyingkwargshere is safe, and consistent to most other code.