Add standalone function to join FSAs for FBW V2 op consumption #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build_batched_fsafunction is a nice utility function that can be used if you have your own FSAs already built somehow and you want to join them. However, as the code is currently, we have to build an object of any subclass of_RasrFsaBuilderFbw2. This is cumbersome for the user, who has to provide an extra path in the code that represents the RASR config, and wait for the object to be created (which involves extra overhead, lots of debugging messages in the log, etc). It would be ideal to use thebuild_batched_fsafunction without having to explicitly create any instance.This PR sets the
build_batched_fsafunction as static.I also took the liberty of setting
apply_tdp_scale_to_fsa_tupleas static, but this is not too relevant for my use case.