-
Notifications
You must be signed in to change notification settings - Fork 16
Score sentence-end transitions with LabelScorer in new search #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SimBe195
wants to merge
23
commits into
master
Choose a base branch
from
sentence_end_handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7502b82
Add TransitionLabelScorer
SimBe195 7430001
Rewrite docstring
SimBe195 2a6272e
Clean up includes
SimBe195 7e325e1
Rewrite docstring again
SimBe195 a276136
Merge branch 'master' into tdp_label_scorer
SimBe195 d2d78fe
Refactor params to string list with compile time check
SimBe195 303fa46
Remove transitionTypeToIndex function and revert associated changes
SimBe195 ddd75c7
Revert unnecessary static_cast
SimBe195 b856c1e
Change std=c++17 to c++20
SimBe195 70699c0
Merge remote-tracking branch 'origin/version-bump' into tdp_label_scorer
SimBe195 5b89d0f
Move transition type string array to LabelScorer.hh
SimBe195 b9d919b
Move transitionTypeArray to protected space
SimBe195 54bee17
Add sentence-end transition to enum
SimBe195 3dc887b
Sentence-end handling for lexiconfree-search
SimBe195 b1ba86a
Add finalStates collection to PersistentStateTree
SimBe195 667f558
Sentence-end handling for tree-search
SimBe195 1795685
Merge branch 'master' into tdp_label_scorer
SimBe195 98b824f
Merge branch 'tdp_label_scorer' into sentence_end_handling
SimBe195 dfdcfe7
Allow no pronunciations of sentence-end
SimBe195 aa099a4
Add sentence-end-index as member and to inferTransitionType in TreeTi…
SimBe195 a04c2f9
Change log to warning when sentence-end is not included in tree
SimBe195 1ee5547
Merge branch 'master' into sentence_end_handling
SimBe195 d4f6202
Suggestions from code review
SimBe195 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.