Skip to content

Conversation

@curufinwe
Copy link
Contributor

Mostly whitespace changes, but also some refactoring / minor fixes.

@curufinwe
Copy link
Contributor Author

This started because I was annoyed with gcc complaining about deprecated function usage that I already fixed in the AppTek codebase and then morphed quickly into let's backport as much as possible to reduce friction in the future.

@larissakl
Copy link
Contributor

I just ran a test with a CTC in the AdvancedTreeSearch. I directly compared the result from the current version on master and this commit and unfortunately I'm observing a degradation from 7.26% to 7.39% WER.

@curufinwe
Copy link
Contributor Author

Once again it was the LM Lookahead. I'm now getting 7.26% now, but maybe you @larissakl could confirm that. Thanks!

@larissakl
Copy link
Contributor

Ah, exactly the same loop again. At least this time it didn't take us a year to notice that 😄

Copy link
Contributor

@larissakl larissakl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I checked that the AdvancedTreeSearch and the TreeTimesyncBeamSearch produce the same output with one of my test setups and I had a manual look through some files I consider important and that looks good. However I cannot guarantee that other tools are not broken/affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants