(Extend some tests) (Earlier this was a huge PR) #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
6 times, most recently
from
0a00094 to
bbe57d1
Compare
This comment has been minimized.
This comment has been minimized.
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
from
bbe57d1 to
547b30a
Compare
This comment has been minimized.
This comment has been minimized.
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
16 times, most recently
from
8ed8897 to
efc4ba8
Compare
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
3 times, most recently
from
9b2e5f2 to
534c017
Compare
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
2 times, most recently
from
a849579 to
067df56
Compare
This comment has been minimized.
This comment has been minimized.
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
2 times, most recently
from
0ab0943 to
49a0f85
Compare
|
Most of this was merged now as part of #613. |
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
from
49a0f85 to
d2c8ed2
Compare
albertz
changed the title
|
I renamed this PR for the remaining few commits, which can be merged now (once tests are passing). |
Merged
add debug_runtime_sanity_checks
add debug_runtime_sanity_checks
albertz
force-pushed
the
albert-generalized-self-att-wip-2021-09-01
branch
from
d2c8ed2 to
ac05603
Compare
albertz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved out from #589. Ultimately for #391.
This was originally a very big PR, which then successively got split up and moved to other PRs (#599 #600 #601 #602 #603 #604 #605 #606 #607 #608 #609 #610 #611 #612 #613 #614 #615 #616 #617 #618 #619 #620 #621 #622 #623 #624), until some remaining small things here (some tests only).
For finding pairs/sets of commits to squash together (and move to separate PRs), I'm using this script (explained here), which finds pairs of commits which reduce the diff over each commit individually.
Some discussion about how to manage the cleanup is here (dev.to) or here (Reddit).