SliceNdLayer now uses GatherLayer to get the slices. #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
albertz
reviewed
Sep 7, 2021
robin-p-schmitt
force-pushed
the
schmitt-slicend-use-gatherlayer
branch
from
d5d46f6 to
4ccf73b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
albertz
reviewed
Sep 12, 2021
albertz
reviewed
Sep 12, 2021
albertz
reviewed
Sep 12, 2021
robin-p-schmitt
commented
Sep 13, 2021
robin-p-schmitt
force-pushed
the
schmitt-slicend-use-gatherlayer
branch
from
4ccf73b to
fad90d0
Compare
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
albertz
reviewed
Sep 14, 2021
…B,T] when optimized out of the loop
robin-p-schmitt
force-pushed
the
schmitt-slicend-use-gatherlayer
branch
from
a4f220d to
0e563b3
Compare
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
|
This might also be interesting for @mmz33 |
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
albertz
reviewed
Sep 16, 2021
|
Despite my remaining comments, I think this PR is ready, or not? You should then mark it as "ready for review". |
albertz
approved these changes
Sep 16, 2021
|
Looks good now. I merged it now. In case you see further problems, open a new PR with proposed changes/fixes. And also for your follow up changes/extensions, please open a new PR. |
This was referenced Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start argument of SliceNdLayer can now be of any shape and not only of shape (B,) as before. I am not 100% sure if we need any asserts to check for shapes or so. But I think it should work for any non-exotic shapes.
@Zettelkasten #625