Ensure the correct file makes it into the location field#126
Merged
kylekthompson merged 6 commits intomainfrom May 13, 2025
Merged
Ensure the correct file makes it into the location field#126kylekthompson merged 6 commits intomainfrom
kylekthompson merged 6 commits intomainfrom
Conversation
kylekthompson
force-pushed
the
kt/fix-shared-examples-file-location
branch
2 times, most recently
from
04fec56 to
2381cec
Compare
kylekthompson
force-pushed
the
kt/fix-shared-examples-file-location
branch
from
2381cec to
5870b55
Compare
tonywok
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running shared examples, rspec's
file_pathis the shared example itself, but the actual test is being run as part of the file indicated by the example'sid