This repository was archived by the owner on Jan 20, 2023. It is now read-only.
Add getVolume and setVolume for Android and iOS#42
Open
joelfaul wants to merge 7 commits intorxlabz:masterfrom
Open
Add getVolume and setVolume for Android and iOS#42joelfaul wants to merge 7 commits intorxlabz:masterfrom
joelfaul wants to merge 7 commits intorxlabz:masterfrom
Conversation
…to klinki-add-volume # Conflicts: # android/src/main/java/bz/rxla/audioplayer/AudioplayerPlugin.java # example/lib/main.dart # lib/audioplayer.dart
Klinki add volume
…ume and mute) and to group playback position items (seek slider and circle progress indicator)
|
I went ahead and forked this project and it is available at https://github.com/emostar/audioplayer and published at https://pub.dartlang.org/packages/audioplayer2. When I get a chance, I'd like to see about adding this PR to the forked project, but it may be faster for you to do it yourself as you are more familiar with the changes. |
|
I want to use the volume control, how could I do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the fork started by klinki to implement setVolume on Android, brought it current and then added getVolume. Also implemented both of these for iOS.
Since iOS uses a double from 0.0 to 1.0 for volume and Android uses a varying range of integers, I tried to normalize to 0 to 100 for all platforms. However, I am not an Android developer and I had trouble getting the functions for reading min and max volume on Android to work. So I commented that code out. It is still useful as is. But I think it would be better if the normalization worked in case someone more familiar with building for Android can get those to work.