Skip to content

Conversation

@BIightning
Copy link
Contributor

@BIightning BIightning commented Sep 22, 2024

Implemented input events as discussed in #33.

Tested functionality with StreamDeck Plus and Mini.

@BIightning
Copy link
Contributor Author

BIightning commented Sep 22, 2024

Thinking about it again, I am not sure if introducing lifetimes into the library by letting the Input Manager instance hold a mutable ref to a deck is a good idea, we could just move the deck into the manager, make it public and access it via manager.deck if we need it.

That would be much easier to use imo.

What do you think @ryankurte ?

@ryankurte
Copy link
Owner

ryankurte commented Sep 22, 2024

hey overall looks good, i think you are correct about it is more straightforward to just pass the deck instance into the manager (so long as it remains optional as not to break existing uses), and if folks have more complex needs we can look at that in the future (or it can be implemented outside the library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants