Skip to content

Conversation

@ryanmac
Copy link
Owner

@ryanmac ryanmac commented Jul 25, 2025

Summary

  • Fixes the "Input required and not supplied: github-token" error that users were experiencing
  • Updates documentation to clarify that no manual token setup is required
  • Ensures proper fallback to built-in GitHub token when custom tokens aren't configured

Problem

Users installing Code Conductor in their projects were getting errors from actions/github-script@v7 because:

  1. The pr-review-tasks.yml workflow used ${{ secrets.CONDUCTOR_GITHUB_TOKEN }}
  2. When this secret doesn't exist (which is normal for user projects), it becomes an empty value
  3. actions/github-script requires the github-token parameter to have a value

Solution

  • Updated pr-review-tasks.yml to use ${{ secrets.CONDUCTOR_GITHUB_TOKEN || github.token }}
    • Falls back to the built-in token if the custom secret doesn't exist
    • Maintains backward compatibility for projects that have set up the custom token
  • Updated CLAUDE.md to clarify that most users don't need any token setup
  • Added tests to verify workflow generation uses correct tokens

Test plan

  • Run black on all Python files
  • Verify tests pass: python tests/test_workflow_generation.py
  • Manual testing of workflow execution with and without custom token

Impact

  • User projects will work out-of-the-box without token configuration
  • Existing projects with custom tokens continue to work as before
  • No breaking changes

Fixes the issue reported where GitHub doesn't allow custom secrets with GITHUB_ prefix and users were getting workflow failures.

🤖 Generated with Claude Code

ryanmac and others added 2 commits July 24, 2025 20:03
- Fix pr-review-tasks.yml to use fallback tokens (${{ secrets.CONDUCTOR_GITHUB_TOKEN || github.token }})
- Update CLAUDE.md to clarify that no manual token setup is required for most users
- Ensure workflows generated by setup.py use github.token (not custom secrets)
- Add tests to verify workflow generation uses correct tokens
- Prevent "Input required and not supplied: github-token" errors in user projects

The key issue was that when CONDUCTOR_GITHUB_TOKEN is not set in user projects,
actions/github-script would receive an empty value for github-token parameter.
Now it falls back to the built-in github.token which is always available.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Updated README.md to explicitly state "No GitHub token setup required\!" in multiple places
- Added clarification to conductor-init.sh installation messages
- Emphasized that workflows use GitHub Actions' built-in authentication automatically
- Added note in troubleshooting section about no token setup needed

This ensures users understand they don't need to create or configure any GitHub tokens
for basic Code Conductor functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@ryanmac
Copy link
Owner Author

ryanmac commented Jul 25, 2025

Updated PR with comprehensive documentation fixes

I've added additional changes to ensure users clearly understand that no GitHub token setup is required:

Documentation Updates:

  1. README.md - Added explicit "No GitHub token setup required!" in 3 key locations:

    • In the Claude Code quick start section
    • After the setup instructions
    • In the troubleshooting section
  2. conductor-init.sh - Added clarifications in installation output:

    • "✅ No GitHub token setup required" in the setup complete message
    • Added to Pro Tips: "No GitHub token setup needed—uses built-in authentication"
    • Added to upgrade message: "Token configuration (no manual setup needed)"

Complete Changes in this PR:

  • ✅ Fixed pr-review-tasks.yml to fall back to github.token when custom token isn't available
  • ✅ Updated CLAUDE.md to remove incorrect token setup instructions
  • ✅ Added tests to verify workflow generation uses correct tokens
  • ✅ Updated README.md with clear messaging about no token setup required
  • ✅ Updated conductor-init.sh installation messages

This ensures users won't encounter the "Input required and not supplied: github-token" error and won't waste time trying to set up tokens they don't need.

@ryanmac ryanmac merged commit 6731479 into main Jul 25, 2025
11 checks passed
@ryanmac ryanmac deleted the fix/github-token-documentation branch July 25, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants