Add Server Mono

[caidanw]

Description

Added the font Server Mono, followed the contributing.md guide.

Requirements / Checklist

• Read the Contributing Guidelines
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
  Issue number where discussion took place: #xxx
• If this contains a font/glyph add its origin as background info below (e.g. URL)
• Verified the license of any newly added font, glyph, or glyph set. License is: SIL Open Font License 1.1

What does this Pull Request (PR) do?

Add the Server Mono font

How should this be manually tested?

Any background context you can provide?

Origin: https://github.com/internet-development/www-server-mono

I'm the maintainer of this font, please let me know if there are any questions/concerns and I'd be happy to help.

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

[caidanw]

@ryanoasis @Finii Are either of you able to review this please :)

[Finii]

You requested a review ;-)

The fontfilenames file has been forgotten (but I also hate that the information is scattered so much), probably we should autogenerate that file instead.

(No need for you to do anything, just noticing.)

https://github.com/ryanoasis/nerd-fonts/tree/master/src/unpatched-fonts#regenerating-the-fontfilenames-file

[Finii]

They put 1.0.0 resp. 1.000 into the font file, so that is an upstream bug 😒

Edit:

Also if I remember correctly the version string should not start with "Version ". I see you (?) use Glyphs3, is that autocreated by it? Do not have my Font-MacBook on my right now, so can not check (on a Linux machine right now).

[caidanw]

Just checked the version number and you're right, I've updated it to be accurate. Also I checked in FontForge and I don't see the 'Version ' prefix, I'm re-adding the new font files though so it might fix things.

[caidanw]

Thanks for taking the time to review this and help guide me on the stuff I missed! I really appreciate the effort and knowledge! I agree that it'd be helpful for new folks like myself to have the documentation in one place (or at least pointing to the various places).

---

I noticed a bug when generating the fontfilenames file, I think the script may have been written with an older jq version because the .fonts[$i] gave an error. I slightly modified the script to make it work:

diff --git a/src/unpatched-fonts/README.md b/src/unpatched-fonts/README.md
index be50bdb4..4b597e19 100644
--- a/src/unpatched-fonts/README.md
+++ b/src/unpatched-fonts/README.md
@@ -13,8 +13,8 @@ all the fonts in `fontfilenames`. This can be used via
 
 Just call
 
-        jq -r '.fonts[$i].imagePreviewFontSource' ../../bin/scripts/lib/fonts.json \
+        jq -r '.fonts[].imagePreviewFontSource' ../../bin/scripts/lib/fonts.json \
             | grep -v '\.sfd$' \
             | sed 's/ /\\ /g' \
             | LC_ALL=C sort --ignore-case \
-            > fontfilenames
+            >| fontfilenames

I removed the problematic $i as it was an undeclared jq variable, and I changed the redirection to force overwrite even when folks like myself have noclobber enabled by default.

I can add this change to this PR, but if you'd prefer to keep it separate then I'll let you add it on your own accord.