Skip to content

Extract virtual terminal methods into runtime submodule#211

Merged
ryanoneill merged 2 commits intomainfrom
refactor/split-runtime-mod
Mar 9, 2026
Merged

Extract virtual terminal methods into runtime submodule#211
ryanoneill merged 2 commits intomainfrom
refactor/split-runtime-mod

Conversation

@ryanoneill
Copy link
Owner

Summary

  • Extracts all CaptureBackend-specific impl blocks from src/app/runtime/mod.rs into a new src/app/runtime/virtual_terminal.rs submodule
  • Reduces mod.rs from 1099 lines to 838 lines, bringing it under the 1000-line project limit
  • No public API changes -- all existing types and methods remain accessible

Details

The extracted virtual_terminal.rs (281 lines) contains:

  • Virtual terminal constructors (virtual_terminal, virtual_terminal_with_config, virtual_terminal_with_state, virtual_terminal_with_state_and_config)
  • Event injection (send)
  • Display inspection (display, display_ansi)
  • Cell query convenience methods (cell_at, contains_text, find_text)

Test plan

  • cargo clippy --all-features -- -D warnings passes with zero warnings
  • cargo test --all-features passes all 787 tests (including doc tests)
  • mod.rs is 838 lines (under 1000-line limit)
  • virtual_terminal.rs is 281 lines (well under limit)

🤖 Generated with Claude Code

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.08%. Comparing base (3bddb37) to head (ad9c375).

Files with missing lines Patch % Lines
src/app/runtime/virtual_terminal.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         144      145    +1     
  Lines       12766    12766           
=======================================
  Hits        11756    11756           
  Misses       1010     1010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanoneill ryanoneill force-pushed the refactor/split-runtime-mod branch from cd22cf5 to 89e8aaf Compare March 8, 2026 23:07
Move all CaptureBackend-specific impl blocks from runtime/mod.rs into
runtime/virtual_terminal.rs to bring mod.rs under the 1000-line project
limit (1099 -> 838 lines). The extracted module contains virtual terminal
constructors, event injection, display inspection, and cell query methods.
No public API changes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ryanoneill ryanoneill force-pushed the refactor/split-runtime-mod branch from 89e8aaf to d419cfd Compare March 9, 2026 01:07
Remove extra blank line flagged by cargo fmt.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ryanoneill ryanoneill merged commit f731228 into main Mar 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants