Extract virtual terminal methods into runtime submodule#211
Merged
ryanoneill merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 144 145 +1
Lines 12766 12766
=======================================
Hits 11756 11756
Misses 1010 1010 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd22cf5 to
89e8aaf
Compare
Move all CaptureBackend-specific impl blocks from runtime/mod.rs into runtime/virtual_terminal.rs to bring mod.rs under the 1000-line project limit (1099 -> 838 lines). The extracted module contains virtual terminal constructors, event injection, display inspection, and cell query methods. No public API changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
89e8aaf to
d419cfd
Compare
Remove extra blank line flagged by cargo fmt. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CaptureBackend-specificimplblocks fromsrc/app/runtime/mod.rsinto a newsrc/app/runtime/virtual_terminal.rssubmodulemod.rsfrom 1099 lines to 838 lines, bringing it under the 1000-line project limitDetails
The extracted
virtual_terminal.rs(281 lines) contains:virtual_terminal,virtual_terminal_with_config,virtual_terminal_with_state,virtual_terminal_with_state_and_config)send)display,display_ansi)cell_at,contains_text,find_text)Test plan
cargo clippy --all-features -- -D warningspasses with zero warningscargo test --all-featurespasses all 787 tests (including doc tests)mod.rsis 838 lines (under 1000-line limit)virtual_terminal.rsis 281 lines (well under limit)🤖 Generated with Claude Code