Adds PWA manifest and icons, template updates.#475
Draft
noahlange wants to merge 2 commits intoryceg:masterfrom
Draft
Adds PWA manifest and icons, template updates.#475noahlange wants to merge 2 commits intoryceg:masterfrom
noahlange wants to merge 2 commits intoryceg:masterfrom
Conversation
Collaborator
|
I'm not entirely familiar with how PWAs work but don't we need to genenerate a list of all the app files? |
Contributor
Author
According to Google, the only other thing that's mandatory is a service worker—Chrome didn't indicate there were any other issues when I opened the application panel in the dev tools. |
Owner
|
What's the state of this? Are we shelving the PWA for the moment? |
Contributor
Author
|
I dunno, and I'm not entirely sure what a proper service worker entails. |
Owner
|
Haha! Righto, guess this one will just sit on the backburner while we wait for somebody with a bit more know-how to show us how it's done :) |
ryceg
added
feature request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds a PWA manifest and icons. I made additional changes to the header template and .gitignore file to add the appropriate
<link />tag and un-ignore the manifest.I generated crop dimensions for the icons using smartcrop.js and compressed with pngquant.
Is there a GitHub Issue that this is resolving?
Yes, it's a start on #454. We'll need to create a service worker before it can be closed, however.