Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We intensively did some data evaluation over the recent weeks and gained a lot of insights, which we want to incorporate into pydatatom with the present PR.
The most important learning:
We want to be much more flexible in the evaluation procedure. The
Pipelineconcept has been shown to be too rigid. Instead, we want to have small, composable helper functions, which can be easily replaced. Same is true for the built-in plotting utils. Where we also found that it would be convenient to have a set of plotting utils ready to use but which still give us the freedom to change the plot, e.g.,plot_xyz(fig, ax). We also want to move more of the evaluation process into thepandasdomain. Finally, we need to speedup the histogram calculation by using multiprocessing/threading.Todos
PipelineClickableImageto interactively select points on an imagebbox_gridto fit a (frequency) grid to a bounding boxmeanand (histogram)countsacross aDatasetpydatatom.analysis.threshold.gaussianpydatatom.analysis.threshold.gaussianwith multithreadingbbox_gridfor every combination of three points (there should be a bug when selecting the bottom left, top left and top right boundaries)Datasetto apandas.Dataframe, e.g.,pd.DataFrame(list(dataset))(right now this is really slow)Simon's feedback on pandas column names: