Fix certificate generation failure when SSL_ALT_NAME is empty#38
Merged
Conversation
Co-Authored-By: Ryo Kobayashi <cuba6vst@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix certificate generation failure when SSL_ALT_NAME is empty
Summary
Fixes #35. When
SSL_ALT_NAMEis empty or unset (e.g. users upgrading from older versions who don't have it in theirdocker-compose.yml), theopensslcommand fails withX509V3_parse_list:invalid null namebecause-addext "subjectAltName = "is passed with an empty value.This adds a guard so that
-addextis only included whenSSL_ALT_NAMEis non-empty. When it is empty, the certificate is generated without the SAN extension instead of failing.Review & Testing Checklist for Human
SSL_ALT_NAMEdefined — cert should generate successfully without the SAN extensionSSL_ALT_NAME=DNS:localhost— cert should generate with SAN as before (no regression)openssl x509 -in server.pem -text -noout) in both cases to confirm expected extensionsNotes