-
-
Notifications
You must be signed in to change notification settings - Fork 311
ci: bun pm for pkg-pr-new #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. WalkthroughCI workflows pin specific bun/bunx tool versions and adjust a publish invocation: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ccusage-guide | 7a11a7c | Commit Preview URL Branch Preview URL |
Sep 14 2025, 11:26 AM |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/ci.yaml (2)
54-56: Pin the typos action (don’t use@master).Floating to
masteris a supply‑chain risk. Pin to a tagged release or commit SHA (e.g., v1.29.4).Apply this diff:
- - uses: crate-ci/typos@master + - uses: crate-ci/[email protected] with: config: ./typos.tomlReference marketplace lists versioned tags. (github.com)
13-16: Pin Bun in CI by committing a.bun-versionand usingbun-version-fileReplace
bun-version: latestwithbun-version-file: .bun-versionin the CI jobs and commit a root.bun-versionfile (no root .bun-version found).Locations: .github/workflows/ci.yaml — lines 13-16, 25-28, 42-45, 62-65.
Suggested diff:
- - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 - with: - bun-version: latest + - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 + with: + bun-version-file: .bun-version
🧹 Nitpick comments (1)
.github/workflows/ci.yaml (1)
16-19: Optionally add a formatting check to match team practice.Learnings note: “After code changes, always run: bun run format, bun typecheck, bun run test.” Consider adding a format check step in lint job (e.g.,
bun run format:checkorbun run formatif that’s the convention).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T11:24:24.075Z
Learnt from: CR
PR: ryoppippi/ccusage#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-02T11:24:24.075Z
Learning: After code changes, always run: bun run format, bun typecheck, bun run test
Applied to files:
.github/workflows/ci.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Workers Builds: ccusage-guide
.github/workflows/ci.yaml
Outdated
| bun-version: latest | ||
| - run: bun install --frozen-lockfile | ||
| - run: bunx pkg-pr-new publish | ||
| - run: bunx pkg-pr-new publish --bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix bunx flag placement: use bunx --bun ... (current command passes --bun to pkg-pr-new).
--bun must precede the executable name to be interpreted by bunx; otherwise it’s forwarded to pkg-pr-new (which doesn’t expose a --bun flag), causing a no-op or error. [bunx docs], [pkg.pr.new docs].
Apply this diff:
- - run: bunx pkg-pr-new publish --bun
+ - run: bunx --bun pkg-pr-new publishRefs: bunx requires --bun before the command; pkg.pr.new shows no --bun option. (bun.com)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - run: bunx pkg-pr-new publish --bun | |
| - run: bunx --bun pkg-pr-new publish |
🤖 Prompt for AI Agents
In .github/workflows/ci.yaml around line 46, the workflow currently runs "bunx
pkg-pr-new publish --bun" which incorrectly passes the --bun flag to pkg-pr-new;
move the --bun flag immediately after bunx so the command reads "bunx --bun
pkg-pr-new publish" to ensure bunx interprets the flag and does not forward it
to the pkg-pr-new executable.
stackblitz-labs/pkg.pr.new#398
Summary by CodeRabbit