Skip to content

Conversation

@ryoppippi
Copy link
Owner

@ryoppippi ryoppippi commented Sep 14, 2025

stackblitz-labs/pkg.pr.new#398

Summary by CodeRabbit

  • Chores
    • CI publishing step updated to invoke the package publish tool with a fixed version and Bun-compatible flag to ensure consistent build/publish behavior.
    • Release workflow now pins the changelog tool to a specific version for reproducible release runs.
    • No user-facing changes or impact on application behavior.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link

coderabbitai bot commented Sep 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

CI workflows pin specific bun/bunx tool versions and adjust a publish invocation: ci.yaml changes bunx pkg-pr-new to bunx [email protected] publish --bun; release.yaml pins bun x changelogithub to bun x [email protected]. No other jobs or steps changed.

Changes

Cohort / File(s) Summary
CI workflow: publish invocation & version pin
.github/workflows/ci.yaml
In job npm-publish-dry-run-and-upload-pkg-pr-now, change bunx pkg-pr-new publish to bunx [email protected] publish --bun (pin version and add --bun).
Release workflow: changelog tool version pin
.github/workflows/release.yaml
Replace bun x changelogithub with bun x [email protected] (pin plugin version).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Thump-thump, I hop through CI light,
Pinned my tools and set flags right. 🥕
One version here, one flag to run,
Pipelines tidy, checks are done.
—A cheerful rabbit.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "ci: bun pm for pkg-pr-new" directly references the CI change to use Bun with the pkg-pr-new command and aligns with the workflow edit that adds the --bun flag to the bunx pkg-pr-new publish invocation, so it is concise and relevant to the changeset. It communicates the primary intent to reviewers without being misleading. The phrasing is slightly awkward but still accurately summarizes the main change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7d38c6 and 7a11a7c.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml (1 hunks)
  • .github/workflows/release.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 14, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ccusage-guide 7a11a7c Commit Preview URL

Branch Preview URL
Sep 14 2025, 11:26 AM

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/ryoppippi/ccusage@627

commit: 7a11a7c

@ryoppippi ryoppippi merged commit 509eb8c into main Sep 14, 2025
14 of 15 checks passed
@ryoppippi ryoppippi deleted the bun-pm branch September 14, 2025 11:26
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
.github/workflows/ci.yaml (2)

54-56: Pin the typos action (don’t use @master).

Floating to master is a supply‑chain risk. Pin to a tagged release or commit SHA (e.g., v1.29.4).

Apply this diff:

-      - uses: crate-ci/typos@master
+      - uses: crate-ci/[email protected]
         with:
           config: ./typos.toml

Reference marketplace lists versioned tags. (github.com)


13-16: Pin Bun in CI by committing a .bun-version and using bun-version-file

Replace bun-version: latest with bun-version-file: .bun-version in the CI jobs and commit a root .bun-version file (no root .bun-version found).

Locations: .github/workflows/ci.yaml — lines 13-16, 25-28, 42-45, 62-65.

Suggested diff:

-      - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
-        with:
-          bun-version: latest
+      - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
+        with:
+          bun-version-file: .bun-version
🧹 Nitpick comments (1)
.github/workflows/ci.yaml (1)

16-19: Optionally add a formatting check to match team practice.

Learnings note: “After code changes, always run: bun run format, bun typecheck, bun run test.” Consider adding a format check step in lint job (e.g., bun run format:check or bun run format if that’s the convention).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62f4f23 and d7d38c6.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T11:24:24.075Z
Learnt from: CR
PR: ryoppippi/ccusage#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-02T11:24:24.075Z
Learning: After code changes, always run: bun run format, bun typecheck, bun run test

Applied to files:

  • .github/workflows/ci.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Workers Builds: ccusage-guide

bun-version: latest
- run: bun install --frozen-lockfile
- run: bunx pkg-pr-new publish
- run: bunx pkg-pr-new publish --bun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix bunx flag placement: use bunx --bun ... (current command passes --bun to pkg-pr-new).

--bun must precede the executable name to be interpreted by bunx; otherwise it’s forwarded to pkg-pr-new (which doesn’t expose a --bun flag), causing a no-op or error. [bunx docs], [pkg.pr.new docs].

Apply this diff:

-      - run: bunx pkg-pr-new publish --bun
+      - run: bunx --bun pkg-pr-new publish

Refs: bunx requires --bun before the command; pkg.pr.new shows no --bun option. (bun.com)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- run: bunx pkg-pr-new publish --bun
- run: bunx --bun pkg-pr-new publish
🤖 Prompt for AI Agents
In .github/workflows/ci.yaml around line 46, the workflow currently runs "bunx
pkg-pr-new publish --bun" which incorrectly passes the --bun flag to pkg-pr-new;
move the --bun flag immediately after bunx so the command reads "bunx --bun
pkg-pr-new publish" to ensure bunx interprets the flag and does not forward it
to the pkg-pr-new executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants