-
-
Notifications
You must be signed in to change notification settings - Fork 319
chore: update @ryoppippi/eslint-config to 0.4.0 and remove svelte=false #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@ryoppippi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 56 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughRemoved the explicit svelte: false option from multiple ESLint config files and updated the workspace catalog to @ryoppippi/eslint-config ^0.4.0, with a corresponding devDependency alias tweak in package.json. No other configuration structures or exports were changed. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d109ffe to
d92b5ac
Compare
Summary of ChangesHello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's ESLint setup by upgrading the primary configuration package and removing unnecessary Svelte-related settings. This streamlines the linting process and ensures the project benefits from the latest features and fixes in the ESLint ecosystem. Additionally, a range of other development dependencies have been brought up to date. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
ccusage-guide | e58050c | Sep 21 2025, 04:53 PM |
commit: |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the @ryoppippi/eslint-config dependency to version 0.4.0 and cleans up the ESLint configuration files by removing the svelte: false option, which is now the default. The changes are clear and align with the stated goals. I've identified a minor issue with a redundant dependency definition in pnpm-workspace.yaml that should be addressed to improve maintainability.
pnpm-workspace.yaml
Outdated
| @@ -4,6 +4,7 @@ packages: | |||
| - packages/* | |||
|
|
|||
| catalog: | |||
| '@ryoppippi/eslint-config': 0.4.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d92b5ac to
bd1d1f8
Compare
…te=false - Updated @ryoppippi/eslint-config in lint catalog from ^0.3.7 to ^0.4.0 - Removed svelte: false from all eslint.config.js files as it's now default false - Removed unused @ryoppippi/eslint-config entry from default catalog - Changes affect root, apps/ccusage, apps/mcp, apps/codex, docs, packages/terminal, and packages/internal
bd1d1f8 to
e58050c
Compare
Summary
svelte: falsefrom all eslint.config.js files since svelte is now disabled by defaultChanges
svelte: falseconfiguration from:Test plan
Summary by CodeRabbit